Setting key to something unicode will make it fail#287
Closed
shuhaowu wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
See: https://travis-ci.org/basho/riak-python-client/jobs/14520258 There are two possible fixes: one is let transport deal with it, but that would nullify https://github.com/basho/riak-python-client/blob/master/riak/riak_object.py#L113 Other is to wrap key into a |
Contributor
Author
|
A documentation change would work as well? |
2 tasks
|
This test is useful, but I am closing in favor of more comprehensive changes. See #334. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test case will fail. Working on a fix now.